do not report cascading errors in instanceof operator#737
Merged
Conversation
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
Can you rename this function to isAnyOrObjectTypeOrTypeParameter? I think it would be more readable that way.
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
i don't mind this. But it does seem ike a very 1-off solution. It seems like preventing cascading in teh event of 'unknownType' is something we'd want to do in a lot more places.
Contributor
Author
There was a problem hiding this comment.
We already use this approach almost everywhere in checker.
vladima
added a commit
that referenced
this pull request
Sep 24, 2014
do not report cascading errors in instanceof operator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #733