Conversation
Member
|
Ensure that any tests that you add actually fail prior to the change. |
Contributor
|
we broke this a few times in the last few weeks. we should add a test. |
Contributor
Author
|
@mhegazy @DanielRosenwasser I agree with that. After brief looks into our harness, the mechanism to gather diagnostics is different from when users use command-line. So there will be some modification we need to do to fix that. |
Contributor
|
sure. #7379 is tracking that. |
Contributor
|
👍 |
yuit
added a commit
that referenced
this pull request
Mar 9, 2016
Concat declaration error so we report them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7354
TODO: Add tests