Skip to content

Use the 'skipTrivia' scanner flag for lexical classification#731

Merged
DanielRosenwasser merged 7 commits into
masterfrom
acknowledgeTrivia
Sep 24, 2014
Merged

Use the 'skipTrivia' scanner flag for lexical classification#731
DanielRosenwasser merged 7 commits into
masterfrom
acknowledgeTrivia

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

No description provided.

Comment thread src/services/services.ts Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we create the scanner once when we create the classifier, and set the text instead of creating a new one?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually going to ask you the same. 😄

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

👍

@DanielRosenwasser
Copy link
Copy Markdown
Member Author

@CyrusNajmabadi onComment is no longer needed because we can turn the skipTrivia flag off and get the comments directly.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Sep 24, 2014

👍

DanielRosenwasser added a commit that referenced this pull request Sep 24, 2014
Use the 'skipTrivia' scanner flag for lexical classification
@DanielRosenwasser DanielRosenwasser merged commit dc9c3e1 into master Sep 24, 2014
@DanielRosenwasser DanielRosenwasser deleted the acknowledgeTrivia branch September 24, 2014 17:39
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants