Signature help in the new compiler#726
Merged
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
add comment that this is ok because we have the parse errors from the parser.
Contributor
Author
There was a problem hiding this comment.
Will remove this. Instead I will export the CancellationTokenObject from createLanguageService
Contributor
There was a problem hiding this comment.
I do not see the point of the extra namespace. ts.findPrecedingToken is good enough
Conflicts: src/compiler/checker.ts src/compiler/types.ts src/services/services.ts
JsonFreeman
added a commit
that referenced
this pull request
Sep 24, 2014
Signature help in the new compiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial work on signature help. This handles the simple call case, but does not handle generic functions.