Moved brace matching functionality to use the new syntax tree#724
Merged
Conversation
Contributor
There was a problem hiding this comment.
I would rather we moved getMatchSpans to services.ts, it sees small enough
Member
Author
There was a problem hiding this comment.
Sounds reasonable. I can move it back in, although, I'd like to temporarily continue the review like this so people can contextually compare side by side.
Contributor
|
👍 |
Contributor
|
👍 Just move code into services.ts |
9518ca3 to
3ffed28
Compare
DanielRosenwasser
added a commit
that referenced
this pull request
Sep 23, 2014
Moved brace matching functionality to use the new syntax tree
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.