do not make inferences with the same source\target pair multiple times#7163
Merged
Conversation
Contributor
Author
|
as a subsequent step we can set the maximum depth of nesting when we explore the structure of types during type inference. This approach seems to be promising and it scales better - these are numbers for the same test with max depth = 5
However before moving forward I'd like to verify that setting max depth does not lead to serious regressions in type inference in our real world code test suite. |
Member
|
LGTM, others should take a look |
Contributor
|
👍 |
Member
Contributor
Author
|
no, #7097 is not fixed with this change |
Member
|
Oh well. :( 👍, but with the caveat that my grasp on the caching mechanism is not too strong. |
vladima
added a commit
that referenced
this pull request
Feb 22, 2016
do not make inferences with the same source\target pair multiple times
vladima
added a commit
that referenced
this pull request
Mar 3, 2016
do not make inferences with the same source\target pair multiple times
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
partial fix for #7081
Total compilation time for an original repro case (above) has dropped from +20 minutes to 1.5s (check time: ~0.9s ). However caching is local to every inference session so it still scales pretty badly
Note: I'm not sure how to write a self-contained test for this issue without including
rx.all.d.tsandimmutable.d.ts