Fixes exclude options#7145
Merged
Merged
Conversation
DanielRosenwasser
added a commit
that referenced
this pull request
Feb 19, 2016
Fixes exclude options
| configurations.files = fileNames; | ||
| } | ||
| else { | ||
| configurations.exclude = ["node_modules"]; |
Contributor
There was a problem hiding this comment.
can you add outDir as well?
Contributor
Author
There was a problem hiding this comment.
Sure, what should be the value?
Contributor
|
if outDir is specified, we should add it to the excludes. if not, nothing should be added. |
Contributor
Author
|
Ok I submit a new PR tomorrow. Don't have time today. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #7126