Rever change to EmitOutput.diagnostics#7139
Merged
Merged
Conversation
Contributor
Author
|
//CC @vladima |
Contributor
|
👍 |
Contributor
|
👍 for reverting this. These changes make it hard to support multiple versions (including nightlies) of TypeScript in gulp-typescript. |
mhegazy
added a commit
that referenced
this pull request
Feb 18, 2016
Rever change to EmitOutput.diagnostics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #7133
The break was introduced in #7108, the assumption was that it was not used often, and using getPreEmitDiagnostics should be sufficient, but after examining gulp-typescript extension this does not seem to be the case.