-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Adds the Transform Flags concept for tree transformations #6983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
cadda66
Adds transform flags aggregation to binder and visitor
rbuckton ba9181c
Merge branch 'transforms-visitor' into transforms-flags
rbuckton 1e35593
Adds the transformFiles API
rbuckton 34489a4
Merge branch 'transforms-visitor' into transforms-flags
rbuckton cbb910a
Merge branch 'transforms-flags' into transforms-transformer
rbuckton 1a0b877
Merge branch 'transforms-visitor' into transforms-flags
rbuckton 51dd27a
Moved TreansformFlags assertions after markers
rbuckton 6fa4002
Merge branch 'transforms-flags' into transforms-transformer
rbuckton 0f2bbb1
Moved LexicalEnvironment to types.ts, minor fixes
rbuckton 6b381ec
Added printer
rbuckton fb19e81
Fixed linter error
rbuckton e545f1b
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 49d2d93
Adds destructuring logic and placeholders for each transformer.
rbuckton f948b14
Adds the TypeScript transformer
rbuckton 4577441
Merge branch 'transforms-visitor' into transforms-flags
rbuckton 319ff61
PR Feedback
rbuckton ceae78b
Merge branch 'transforms-flags' into transforms-transformer
rbuckton f8ed021
PR feedback and cleanup
rbuckton ab811f9
Updates to TransformationContext and transformer.ts
rbuckton c634a36
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 0f16e68
PR Feedback
rbuckton 8ec3932
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 357171f
PR feedback, switched to getEmitScriptTarget/getEmitModuleKind
rbuckton c4dc2ae
Merge branch 'transforms-transformer' into transforms-transformer-ts
rbuckton 6c0551f
Adds initial jsx transformer
rbuckton 1ceb02a
Added initial ES7 transformer
rbuckton dd2dc78
Enables source maps for exceptions thrown in the compiler (when avail…
rbuckton c759b63
Adds ES6 transformer
rbuckton 39628d7
Added CommonJS/AMD/UMD module transformer
rbuckton 5564537
Added initial SystemJS transformer.
rbuckton ab8e83e
Merge branch 'transforms-visitor' into transforms-flags
rbuckton cd7c229
Merged some changes from other branches.
rbuckton 024eff1
Merge branch 'transforms-flags' into transforms-transformer
rbuckton 11d54ba
Merged some changes from other branches.
rbuckton 2ab8877
Fix for new linter warning
rbuckton 8e0d28e
Merge branch 'transforms-flags' into transforms-transformer
rbuckton 80f89a1
PR feedback
rbuckton 7d72c18
Merge branch 'transforms-flags' into transforms-transformer
rbuckton 90a317f
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 6d27336
Merged some changes from other branches.
rbuckton f52a30b
Merged some changes from other branches.
rbuckton 64e7aa8
PR Feedback.
rbuckton 0a325ee
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton 3d8cb51
Merge branch 'transforms-transformer-ts' into transforms-transformer-jsx
rbuckton 0145009
Merge branch 'transforms-transformer-jsx' into transforms-transformer…
rbuckton dc0b043
Merge branch 'transforms-transformer-es7' into transforms-transformer…
rbuckton 0b64048
Merge branch 'transforms-transformer-es6' into transforms-transformer…
rbuckton f3179da
Fixed issue with test dependencies
rbuckton 617e511
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 61fe61b
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton c166a2d
Merge branch 'transforms-transformer-ts' into transforms-transformer-jsx
rbuckton 5b7bd63
Merge branch 'transforms-transformer-jsx' into transforms-transformer…
rbuckton 6d111e3
Merge branch 'transforms-transformer-es7' into transforms-transformer…
rbuckton 4a81dde
Fixed issue with smartindenter
rbuckton 2e47e2e
Merge branch 'transforms-transformer' into transforms-printer
rbuckton e5cd8fe
Added temporary compat flag to control emit output to fix tests
rbuckton b3adade
PR Feedback
rbuckton 61f3ba6
Merge branch 'transforms-transformer' into transforms-printer
rbuckton ad314b0
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton 0937cec
Added additional auto-parenthesizing to visitor.
rbuckton 98ab964
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 52c62d0
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton f484ff4
Reenabled transforms.
rbuckton 635347e
Fixed typo in visitEachChild
rbuckton 9871d3b
Merge branch 'transforms-transformer' into transforms-printer
rbuckton de9866f
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton 02b85f8
PR feedback
rbuckton f92c24b
Removed unused liftNode function
rbuckton 40b61fb
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 4f03b31
Updated lift behavior
rbuckton 75b2181
Merge branch 'transforms-transformer' into transforms-printer
rbuckton 951ce55
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton 08036b7
Fixed linter warnings, added comments and minor cleanup.
rbuckton 608822d
Merge branch 'transforms-transformer-ts' into transforms-transformer-jsx
rbuckton c9f5253
Fixed linter warnings
rbuckton 25f4102
Reverted change to emitter to force use of printFiles
rbuckton cde3b34
Merge branch 'transforms-transformer-ts' into transforms-transformer-jsx
rbuckton 5a9b131
Merge branch 'transforms-transformer-jsx' into transforms-transformer…
rbuckton 78dfab8
Merge branch 'transforms-transformer-es7' into transforms-transformer…
rbuckton 0d8e152
Merge branch 'transforms-transformer-es6' into transforms-transformer…
rbuckton 72bfd2f
Fixed linter warnings.
rbuckton cd2cf7d
PR Feedback and defer makeUniqueName/getGeneratedNameForNode to printer.
rbuckton b1d8828
Remove transformCompatibleEmit flag and make it the default.
rbuckton 8e5e5f8
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton 359875b
PR Feedback
rbuckton fe7ad5f
Minor tweaks to naming
rbuckton a0dbe76
PR Feedback
rbuckton a7f9cda
Merge branch 'transforms-transformer-ts' into transforms-transformer-jsx
rbuckton 7d05ba2
Fixed visitJsxText, plus PR Feedback
rbuckton 186f5c8
PR Feedback
rbuckton 2c9cd2e
Merge branch 'transforms-transformer-jsx' into transforms-transformer…
rbuckton 88e1772
Merge branch 'transforms-transformer-es7' into transforms-transformer…
rbuckton 30433c2
ES6 cleanup
rbuckton 2d2709f
Fixed typo in visitCallExpression
rbuckton 70cbb9b
Merge branch 'transforms-transformer-es6' into transforms-transformer…
rbuckton ebb4764
Switch from onBefore/onAfterEmitNode to onEmitNode
rbuckton e66e51d
Merge branch 'transforms-printer' into transforms-transformer-ts
rbuckton 8b35af4
Switched to onEmitNode
rbuckton 1fdaf74
Merge branch 'transforms-transformer-ts' into transforms-transformer-jsx
rbuckton 593fbd4
Merge branch 'transforms-transformer-jsx' into transforms-transformer…
rbuckton 7b28b48
Merge branch 'transforms-transformer-es7' into transforms-transformer…
rbuckton 1c73818
Switched to onEmitNode
rbuckton c4a75ba
Merge branch 'transforms-transformer-es6' into transforms-transformer…
rbuckton 72eebdb
Switched to onEmitNode
rbuckton 1cf183b
Fixed invalid assertion in ts transformer
rbuckton d89e21a
General fixes and cleanup
rbuckton 5b8cf96
Moved modifier related flags to separate enum
rbuckton 99e6ad8
Removed ModifiersArray
rbuckton 47cdfbe
Add support for array return values from visitors
rbuckton 2699bf9
Removed NodeArrayNode in favor of arrays
rbuckton 94018a1
cleaned up assertions and removed flattenNodes.
rbuckton ad0dd4e
Fixed perf issue in binder, plus PR feedback
rbuckton 44ca7d4
Updated baselines
rbuckton ae7843d
PR Feedback
rbuckton 3c5f170
Merge pull request #7206 from Microsoft/transforms-transformer-module
rbuckton 07a3d18
Merge pull request #7194 from Microsoft/transforms-transformer-es6
rbuckton cc00f4c
Merge pull request #7193 from Microsoft/transforms-transformer-es7
rbuckton 829a9df
Merge pull request #7192 from Microsoft/transforms-transformer-jsx
rbuckton ca9148e
Merge pull request #7191 from Microsoft/transforms-transformer-ts
rbuckton 85ae53d
Merge pull request #6987 from Microsoft/transforms-printer
rbuckton a212e2b
Merge pull request #6986 from Microsoft/transforms-transformer
rbuckton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these assertions actually get acted on in a later PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and the example above shows how they are used. The bitmask of an assertion is merely a shortcut used to ensure that both the "this node is a" flag (e.g.
TypeScript) and "the subtree containing this node has a" flag (e.g.ContainsTypeScript) are set on the node.