add 'skipTrivia' parameter to scanner#696
Merged
Merged
Conversation
Contributor
|
👍 |
vladima
added a commit
that referenced
this pull request
Sep 18, 2014
add 'skipTrivia' parameter to scanner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
skipTriiviaparameter tocreateScannerfunction. When it istrue- scanner will return only tokens, if it isfalse- both tokens and trivia.This includes only change in the scanner so this logic can be used in formatting and classification. I've kept implementation of
skipTriviaandgetCommentRangesintact because switching them to use scanner has a negative perf impact - 2x emit time comparing to current implementation