propagate back assignments to block scoped binding from the loop body#6898
Merged
Conversation
| }; | ||
| var out_i_1; | ||
| for (var i = 0; i < 9; ++i) { | ||
| out_i_1 = i; |
Contributor
There was a problem hiding this comment.
i do not think we need this, since the function is guaranteed to set the correct value.
Contributor
|
👍 with the removal of the extra assignment. |
vladima
added a commit
that referenced
this pull request
Feb 4, 2016
propagate back assignments to block scoped binding from the loop body
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6877.
NOTE: it will be cleaner to emit loop body as
instead of writing copy snippet at every point where control flow exits loop. However currently V8 does not optimize protected regions so between prettiness and perf of generated code I'd prefer to favor the second one