Recognize = as equivalent to ? in JSDoc signatures#6869
Merged
Conversation
Member
There was a problem hiding this comment.
Shouldn't this be what we consider a "synthetic" node? That usually uses an start of -1 or something.
Member
Author
There was a problem hiding this comment.
It's not synthetic -- it's backed by a real span
Member
There was a problem hiding this comment.
Shouldn't the SyntaxKind match the actual contents of token? Here we are marking a '=' token as a QuestionToken.
I get it works, but seems a little dirty. Is there precedence in the code for marking tokens with a SyntaxKind which doesn't match the token contents? If not, doesn't seem like we should start.
Member
Author
|
Any other comments? @billti ? |
Member
|
👍 |
RyanCavanaugh
added a commit
that referenced
this pull request
Feb 4, 2016
Recognize `=` as equivalent to `?` in JSDoc signatures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6811