Skip to content

Parse JSDoc comments for ES6 class constructors and methods#6680

Merged
RyanCavanaugh merged 2 commits into
microsoft:masterfrom
RyanCavanaugh:fix6646
Feb 2, 2016
Merged

Parse JSDoc comments for ES6 class constructors and methods#6680
RyanCavanaugh merged 2 commits into
microsoft:masterfrom
RyanCavanaugh:fix6646

Conversation

@RyanCavanaugh

Copy link
Copy Markdown
Member

Fixes #6646

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also verify that at a new site you get the correct intellisense/signature help? (i.e. var x = new Something(/* here */))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also add a simple test for method params...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mhegazy

mhegazy commented Feb 2, 2016

Copy link
Copy Markdown
Contributor

👍

@billti

billti commented Feb 2, 2016

Copy link
Copy Markdown
Member

Thanks! 👍

RyanCavanaugh added a commit that referenced this pull request Feb 2, 2016
Parse JSDoc comments for ES6 class constructors and methods
@RyanCavanaugh RyanCavanaugh merged commit 2d7a2f4 into microsoft:master Feb 2, 2016
@RyanCavanaugh RyanCavanaugh deleted the fix6646 branch February 2, 2016 18:48
@billti billti mentioned this pull request Feb 4, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants