break on 'this' type in hasConstraintReferenceTo#6628
Conversation
|
CI build failed because of some random lint errors in files that were not even affected by this PR, looking into this: |
|
pinging @jkillian: it seems that |
There was a problem hiding this comment.
I'd rather you move the new check into the body and break with a comment explaining why you need to do this.
There was a problem hiding this comment.
No, the check is fine here with all the other checks.
|
Thanks for the heads-up @vladima. I'll check to see that things are working with TS 1.9 nightlies and bump that dependency. |
|
@vladima Just published a new |
|
Thanks @jkillian! |
|
@vladima I requested a re-run on Travis. |
|
Fix looks good to me. |
|
pinging @mhegazy should it also go to 1.8? |
break on 'this' type in hasConstraintReferenceTo
|
We will need to port this to 1.8. |
break on 'this' type in hasConstraintReferenceTo
fix proposal for #6592, //cc @ahejlsberg