Repository navigation
Restore behavior of getImmediateAliasedSymbol - #64867
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Open
Andrew Branch (andrewbranch) wants to merge 1 commit into
Andrew Branch (andrewbranch) wants to merge 1 commit into
Conversation
Andrew Branch (andrewbranch)
requested a review
from Anders Hejlsberg (ahejlsberg)
October 19, 2026 16:56
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused change preserves full-resolution callers and adds targeted regression coverage, with no unresolved findings.
No open issues 🎉
What changed in this PR
Restores getImmediateAliasedSymbol compatibility with TypeScript 6, addressing #64532.
Changes:
- Preserves immediate namespace alias targets without recursive resolution or module wrapping.
- Keeps existing full-resolution behavior for other callers.
- Adds async and sync regression tests for module identity and export-assignment aliases.
| File | Description |
|---|---|
| tsc/internal/checker/nodebuilder_hover.go | Keeps full alias resolution for hover expansion. |
| tsc/internal/checker/checker.go | Restores nonrecursive immediate alias lookup. |
| packages/typescript/test/sync/api.test.ts | Adds synchronous alias regression tests. |
| packages/typescript/test/async/api.test.ts | Adds asynchronous alias regression tests. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64532
It looks like microsoft/typescript-go#2168 removed something that was unneeded internally, but necessary to preserve TS 6 API semantics.