Fixes issue https://github.com/Microsoft/TypeScript/issues/528 (Show better error message for unresolved references due to missing prefix)#6469
Merged
Conversation
Contributor
|
👍 |
Member
There was a problem hiding this comment.
Can you change this to
"Cannot find name '{0}'. Did you mean the static member '{1}.{0}'?"
Member
There was a problem hiding this comment.
Maybe @sandersn and @JsonFreeman can weigh in on something better. I prefer my suggestion because it's shorter and less overwhelming for the user.
Member
There was a problem hiding this comment.
I agree, the shorter form sounds better. The this version can be even shorter: "Did you mean the memer 'this.{0}'?"
Member
|
I think it's a little odd that for class C {
static foo: string;
bar() {
let k = foo;
}
}we don't give the appropriate suggestion for using Otherwise, this is an awesome change. Thanks @ShyykoSerhiy! |
DanielRosenwasser
added a commit
that referenced
this pull request
Jan 14, 2016
Fixes issue #528 (Show better error message for unresolved references due to missing prefix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #528