fix(2814): correct misleading error message for functions without bodies#63631
Open
Nabeel-akk wants to merge 1 commit into
Open
fix(2814): correct misleading error message for functions without bodies#63631Nabeel-akk wants to merge 1 commit into
Nabeel-akk wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the TS2814 diagnostic wording to remove the misleading “with bodies” qualifier, since the error can also be reported for body-less function declarations (e.g. overload signatures).
Changes:
- Update the TS2814 message text in
src/compiler/diagnosticMessages.jsonto remove “with bodies”.
Comment on lines
+3793
to
3796
| "Functions can only merge with classes that are ambient.": { | ||
| "category": "Error", | ||
| "code": 2814 | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #63628
The TS2814 error currently says 'Function with bodies can only merge with classes that are ambient.' but the function in question (an overload declaration like unction Foo();) doesn't have a body. This makes the message confusing.
The fix removes the incorrect 'with bodies' qualifier since the error can fire for any function declaration regardless of whether it has a body.