Remove most special treatment of specialized signatures.#6278
Merged
Conversation
…form the same checking on specialized and non-specialized signatures.
Member
Author
|
@ahejlsberg @RyanCavanaugh could you guys take a look at this PR? |
Conflicts: src/compiler/checker.ts
65857ff to
59a1afa
Compare
Member
|
#6732 convinces me we need to get rid of the special treatment. So I'm good with merging this (once you fix the failed integration checks). |
This was referenced Jan 30, 2016
Member
Author
|
@ahejlsberg are we going to port this into 1.8 as well? |
DanielRosenwasser
added a commit
that referenced
this pull request
Feb 2, 2016
Remove most special treatment of specialized signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5659, #6276, and resolves the main issues in #6143
With this change, the only thing that makes a specialized overload "special" is that we will still bubble those signatures to the top for overload resolution. This is done in
reorderCandidates.Specifically, here is the new behavior:
Edit on 2016-01-29: Fixes #6732.