Optionally insert spaces between template string braces#6202
Merged
Conversation
Member
There was a problem hiding this comment.
Not that this should necessarily be a part of this change, but we should separately consider changing Nonempty to NonEmpty
Contributor
Author
There was a problem hiding this comment.
Will that be a breaking change?
Member
There was a problem hiding this comment.
Yyyyes 😢
Never mind I suppose
|
@DanielRosenwasser - any thoughts on my comment from the related thread? What approach are the core TypeScript team taking with respect to formatting? |
Member
Contributor
|
thanks @saschanaz! |
mhegazy
added a commit
that referenced
this pull request
Jan 7, 2016
Optionally insert spaces between template string braces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and remove space between template tag and template string.
Fixes #6195.
Current:
Change:
Default:
Optionally: