Skip to content

Add type definitions for Uint8Array to/from base64 methods #61696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 21 commits into from
Oct 3, 2025
Merged

Add type definitions for Uint8Array to/from base64 methods #61696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
2471626
Add type definitions for `Uint8Array` to/from base64 methods
dontwanttothink May 13, 2025
09db85c
Update baselines
dontwanttothink May 13, 2025
d5f1e1c
Update script target features
dontwanttothink May 16, 2025
f720939
Add tests
dontwanttothink May 16, 2025
ed6539c
Fix typo
dontwanttothink May 16, 2025
3f18d3c
Use method definitions and narrow down type
dontwanttothink Jun 5, 2025
a5df42d
Update baselines
dontwanttothink Jun 5, 2025
7289362
Merge branch 'main' into main
dontwanttothink Jun 30, 2025
5e714bc
Merge branch 'main' into main
dontwanttothink Jul 2, 2025
f4aff51
Merge branch 'microsoft:main' into main
dontwanttothink Sep 22, 2025
8b057c9
Move into `esnext.typedarrays.d.ts`
dontwanttothink Sep 26, 2025
fb157d2
Update baselines
dontwanttothink Sep 26, 2025
44b7036
Fix line endings
dontwanttothink Sep 26, 2025
f28291d
Allow passing `undefined` wherever appropriate
dontwanttothink Oct 3, 2025
9e959c6
Update baselines
dontwanttothink Oct 3, 2025
70bdae0
Update tests to contemplate setting options to 'undefined'
dontwanttothink Oct 3, 2025
29409fa
Again, update baselines
dontwanttothink Oct 3, 2025
ea58c9b
Remove redundant `undefined`s
dontwanttothink Oct 3, 2025
621e973
Again, again update baselines
dontwanttothink Oct 3, 2025
5176640
Remove the test
dontwanttothink Oct 3, 2025
b24705d
Update baselines
dontwanttothink Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@dontwanttothink
dontwanttothink committed May 16, 2025
commit ed6539c677a1e3daf19c53a4dec6b4bb3c4a9f5f
2 changes: 1 addition & 1 deletion src/compiler/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1914,7 +1914,7 @@ export const getScriptTargetFeatures: () => ScriptTargetFeatures = /* @__PURE__
"cause",
],
})),
Uint8Constructor: new Map(Object.entries({
Uint8ArrayConstructor: new Map(Object.entries({
esnext: [
"fromBase64",
"fromHex",
Expand Down
12 changes: 6 additions & 6 deletions tests/baselines/reference/toFromHexBase64(target=es2024).errors.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
toFromHexBase64.ts(1,25): error TS2339: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'.
toFromHexBase64.ts(2,25): error TS2339: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'.
toFromHexBase64.ts(3,25): error TS2339: Property 'fromHex' does not exist on type 'Uint8ArrayConstructor'.
toFromHexBase64.ts(1,25): error TS2550: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
toFromHexBase64.ts(2,25): error TS2550: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
toFromHexBase64.ts(3,25): error TS2550: Property 'fromHex' does not exist on type 'Uint8ArrayConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
toFromHexBase64.ts(12,20): error TS2550: Property 'setFromBase64' does not exist on type 'Uint8Array<ArrayBuffer>'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
toFromHexBase64.ts(13,20): error TS2550: Property 'setFromBase64' does not exist on type 'Uint8Array<ArrayBuffer>'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
toFromHexBase64.ts(14,20): error TS2550: Property 'setFromBase64' does not exist on type 'Uint8Array<ArrayBuffer>'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
Expand All @@ -10,13 +10,13 @@ toFromHexBase64.ts(20,20): error TS2550: Property 'setFromHex' does not exist on
==== toFromHexBase64.ts (7 errors) ====
const arr1 = Uint8Array.fromBase64("AAAAAA==");
~~~~~~~~~~
!!! error TS2339: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'.
!!! error TS2550: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
const arr2 = Uint8Array.fromBase64("AAAAAA", { alphabet: "base64url" });
~~~~~~~~~~
!!! error TS2339: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'.
!!! error TS2550: Property 'fromBase64' does not exist on type 'Uint8ArrayConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.
const arr3 = Uint8Array.fromHex("000000");
~~~~~~~
!!! error TS2339: Property 'fromHex' does not exist on type 'Uint8ArrayConstructor'.
!!! error TS2550: Property 'fromHex' does not exist on type 'Uint8ArrayConstructor'. Do you need to change your target library? Try changing the 'lib' compiler option to 'esnext' or later.

const encodedBase64_1 = arr1.toBase64();
const encodedBase64_2 = arr1.toBase64({ alphabet: "base64" });
Expand Down