Apply tslint to services.ts file#6141
Merged
Merged
Conversation
Member
|
GitHub really sucks here. |
Member
|
At least we have gist: https://gist.github.com/DanielRosenwasser/03a80fe85cddf40201d9 |
Member
|
There are a few places where you've touched the comments and switched Anyhow, that's not all that big of a deal, so 👍 |
Contributor
Author
|
@DanielRosenwasser yeah. the list of lint errors are too big so I end up find-replace for let/const conversion 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slowly applying lint rule to services folder as doing all at once will be quite insane 😅