Fix rename/document-highlight/find reference in parameter property declaration#6084
Conversation
There was a problem hiding this comment.
isParameterPropertyDeclaration
There was a problem hiding this comment.
It is currently only services file as to fix entire services folder for linting will be a large fix that is not necessary have to be done in one-go
There was a problem hiding this comment.
I wonder if the return type here should make it explicit over which is which (i.e.{ parameterSymbol: Symbol; propertySymbol: Symbol; }). Perhaps that's overkill. Thoughts @vladima, @CyrusNajmabadi?
|
I can't see any of the changes in |
|
@DanielRosenwasser yes I can do that. I forgot that github can't show diff of too many change 😅 |
There was a problem hiding this comment.
I wonder if it's permissible to repeat the same symbol, but I think it should be fine.
There was a problem hiding this comment.
How can it be the same symbol though?
|
👍 |
There was a problem hiding this comment.
This should be assertHasRanges
Fix rename/document-highlight/find reference in parameter property declaration
fix #4686 rename/document highlighting/ find reference in parameter property declaration.