Fix for #5058 - Exclude implemented interface functions from autocompletion suggestions.#5979
Merged
Merged
Conversation
… autocompletion suggestions.
|
Hi @DanCorder, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
Member
There was a problem hiding this comment.
Can you get rid of I2 and just use I1 to keep the test minimal?
Member
|
Thanks for the PR @DanCorder. I left some feedback but all else looks great. As another heads up, GitHub doesn't link the issues unless the issue number is referenced in the PR body. I've gone ahead and added that for you. |
Contributor
Author
|
Thanks for the heads up, I've updated the test. |
DanielRosenwasser
added a commit
that referenced
this pull request
Dec 7, 2015
Fix for #5058 - Exclude implemented interface functions from autocompletion suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue and doesn't break any other tests, however I don't understand the comment on line 3751. Hopefully I haven't missed anything.
Edit by @DanielRosenwasser: Fixes #5058