Skip to content

Explicitly list tuple overloads for Promise.all.#5973

Merged
sandersn merged 1 commit into
masterfrom
improve-type-of-Promise.all
Dec 7, 2015
Merged

Explicitly list tuple overloads for Promise.all.#5973
sandersn merged 1 commit into
masterfrom
improve-type-of-Promise.all

Conversation

@sandersn
Copy link
Copy Markdown
Member

@sandersn sandersn commented Dec 7, 2015

Previously, the array type would infer a union type for multiple arguments of differing types. The original overload remains, but I added 9 tuple-based overloads to support up to 10 heterogeneously-typed arguments.

Fixes #5935.

Previously, the array type would infer a union type for multiple arguments
of differing types. The original overload remains, but I added 9
tuple-based overloads to support up to 10 heterogeneously-typed arguments.
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Dec 7, 2015

thanks! 👍

sandersn added a commit that referenced this pull request Dec 7, 2015
Explicitly list tuple overloads for `Promise.all`.
@sandersn sandersn merged commit 31f56fd into master Dec 7, 2015
@sandersn sandersn deleted the improve-type-of-Promise.all branch December 7, 2015 18:19
@OliverJAsh
Copy link
Copy Markdown
Contributor

How can I use these type definitions? They are not available at http://www.typescriptlang.org/playground/

@sandersn
Copy link
Copy Markdown
Member Author

We only update the playground when there's a release, so it's still on 1.7.x. It'll get the new types for 1.8.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants