Don’t try to recreate AutoImportProvider after giving up because of too many dependencies until program structure changes#59692
Merged
andrewbranch merged 9 commits intoAug 21, 2024
Conversation
sheetalkamat
approved these changes
Aug 20, 2024
sheetalkamat
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the following sequence in a TS Server log:
host.getPackageJsonAutoImportProvider()gets called multiple times during completions. When an AutoImportProvider program exists, it’s cached and updated appropriately. But when one fails to be created because either it finds no dependencies or too many dependencies, the result of that failure wasn’t being stored; instead, we tried to recreate it every time we attempt to get it from the host.View commit d44feec in isolation to see the desired effect in the server logs.