Skip to content

Drop unnecessary type arguments in the isolated declarations quick fix #59665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakebailey merged 13 commits into from
Sep 16, 2024
Merged

Drop unnecessary type arguments in the isolated declarations quick fix #59665

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dd29423
Create a few (failing) test cases of https://github.com/microsoft/Typ…
blickly Jul 25, 2024
6f8e37d
Add functionality to convert a ReferenceType into a "minimal" TypeNode
blickly Aug 8, 2024
b0bc68f
Add a few more test cases of the "negative" cases
blickly Aug 8, 2024
de61d6d
First fixes based on code review feedback
blickly Aug 19, 2024
b0b1e02
Update src/compiler/types.ts
blickly Aug 19, 2024
943761b
Fix unused import
blickly Aug 19, 2024
d53552f
Run dprint to fix formatting
blickly Aug 19, 2024
77ac42f
Use factory methods to create new AST node instead of mutating
blickly Aug 19, 2024
71c092a
Avoid updating nodes when unnecessary
blickly Aug 20, 2024
14deb8e
Add example case with a inferred generator return
blickly Aug 20, 2024
a603aa2
Update tests/cases/fourslash/codeFixMissingTypeAnnotationOnExports52-…
blickly Aug 29, 2024
4e21657
Update src/services/codefixes/helpers.ts
blickly Aug 29, 2024
cd0cd4e
Fix typo in filename
blickly Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run dprint to fix formatting
  • Loading branch information
@blickly
blickly committed Aug 19, 2024
commit d53552f35379f9f3781d2f9b8d227288983f3ba0
4 changes: 2 additions & 2 deletions src/services/codefixes/fixMissingTypeAnnotationOnExports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ import {
createImportAdder,
eachDiagnostic,
registerCodeFix,
typeNodeToAutoImportableTypeNode,
typePredicateToAutoImportableTypeNode,
typeToMinimizedReferenceType,
typeNodeToAutoImportableTypeNode,
} from "../_namespaces/ts.codefix.js";
import {
ArrayBindingPattern,
Expand Down Expand Up @@ -1097,7 +1097,7 @@ function withContext<T>(
return emptyInferenceResult;
}

function typeToTypeNode(type: Type, enclosingDeclaration: Node, flags = NodeBuilderFlags.None): TypeNode|undefined {
function typeToTypeNode(type: Type, enclosingDeclaration: Node, flags = NodeBuilderFlags.None): TypeNode | undefined {
let isTruncated = false;
const minimizedTypeNode = typeToMinimizedReferenceType(typeChecker, type, enclosingDeclaration, declarationEmitNodeBuilderFlags | flags, declarationEmitInternalNodeBuilderFlags, {
moduleResolverHost: program,
Expand Down
1 change: 0 additions & 1 deletion src/services/codefixes/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,6 @@ export function typeToMinimizedReferenceType(checker: TypeChecker, type: Type, c
(typeNode as any).typeArguments = typeNode.typeArguments.slice(0, cutoff);
Comment thread
jakebailey marked this conversation as resolved.
Outdated
}
}

}
return typeNode;
}
Expand Down