Skip to content

Refactored node builder flags and tests #59440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armanio123 merged 11 commits into from
Aug 8, 2024
Merged

Refactored node builder flags and tests #59440

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7d434b7
Refactored node builder flags and tests
Jul 27, 2024
c5ffae5
Fixed typos
Jul 27, 2024
d6b7c2a
Fixed format errors
Jul 27, 2024
1247fcf
Revert "Fixed format errors"
Jul 30, 2024
736ab40
Revert "Fixed typos"
Jul 30, 2024
5854210
Revert "Refactored node builder flags and tests"
Jul 30, 2024
3185381
Added flag internalNodeBuilderFlags
Aug 3, 2024
2e52805
Missing internalFlags
Aug 3, 2024
96ee387
Return AllowUnresolvedTypes
Aug 5, 2024
66daac1
Add AllowUnresolveNames flag to all NoTruncation
Aug 8, 2024
330c65b
Rollback TypeFormatFlags.NoTruncation
Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Fixed format errors" 
This reverts commit d6b7c2a.
  • Loading branch information
Armando Aguirre Sepulveda committed Jul 30, 2024
commit 1247fcff018b8b08e0f689f178823612e773b7d5
2 changes: 1 addition & 1 deletion src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,6 @@ import {
Node,
NodeArray,
NodeBuilderFlags,
NodeBuilderFlagsIgnoreErrors,
nodeCanBeDecorated,
NodeCheckFlags,
NodeFlags,
Expand Down Expand Up @@ -1120,6 +1119,7 @@ import {
WideningContext,
WithStatement,
YieldExpression,
NodeBuilderFlagsIgnoreErrors,
} from "./_namespaces/ts.js";
import * as moduleSpecifiers from "./_namespaces/ts.moduleSpecifiers.js";
import * as performance from "./_namespaces/ts.performance.js";
Expand Down
13 changes: 7 additions & 6 deletions src/compiler/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5474,12 +5474,13 @@ export const NodeBuilderFlags = {
InInitialEntityName : 1n << 24n, // Set when writing the LHS of an entity name or entity name expression
}

export const NodeBuilderFlagsIgnoreErrors = NodeBuilderFlags.AllowThisInObjectLiteral
| NodeBuilderFlags.AllowQualifiedNameInPlaceOfIdentifier
| NodeBuilderFlags.AllowAnonymousIdentifier
| NodeBuilderFlags.AllowEmptyUnionOrIntersection
| NodeBuilderFlags.AllowEmptyTuple
| NodeBuilderFlags.AllowEmptyIndexInfoType
export const NodeBuilderFlagsIgnoreErrors =
NodeBuilderFlags.AllowThisInObjectLiteral
| NodeBuilderFlags.AllowQualifiedNameInPlaceOfIdentifier
| NodeBuilderFlags.AllowAnonymousIdentifier
| NodeBuilderFlags.AllowEmptyUnionOrIntersection
| NodeBuilderFlags.AllowEmptyTuple
| NodeBuilderFlags.AllowEmptyIndexInfoType
| NodeBuilderFlags.AllowNodeModulesRelativePaths;

// Ensure the shared flags between this and `NodeBuilderFlags` stay in alignment
Expand Down