Skip to content

Extract node type printer #59282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 26 commits into from
Sep 30, 2024
Merged

Extract node type printer #59282

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
457e819
Extract node type printer
dragomirtitian Jul 15, 2024
ba88432
Fix knip and small issue.
dragomirtitian Jul 15, 2024
8cf6024
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Jul 15, 2024
c407602
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Aug 6, 2024
001eef0
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Sep 16, 2024
8b6073e
Fixed tests.
dragomirtitian Sep 16, 2024
3cffdc9
Do not serialize mapped type properties. Improve checking if the anno…
dragomirtitian Sep 18, 2024
96c7700
Fix printing for spread of accessors.
dragomirtitian Sep 18, 2024
489c4ff
Fix local inference fallback for arrays and object literals.
dragomirtitian Sep 18, 2024
42ccddf
Add undefined to optional properties if type is not form an assertion.
dragomirtitian Sep 18, 2024
9efab9d
Reduce amount of type instantiations.
dragomirtitian Sep 18, 2024
d06e874
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Sep 18, 2024
429c24f
Fix new isolated declarations error in TSC.
dragomirtitian Sep 18, 2024
7342233
Changed error message for accessors.
dragomirtitian Sep 19, 2024
9bd26f9
Do not reuse import types with assert keyword.
dragomirtitian Sep 19, 2024
a751214
Do not use syntactic printer if we don't have an enclosing scope.
dragomirtitian Sep 25, 2024
5e93ef3
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Sep 25, 2024
50a60d9
Fix formatting issue
dragomirtitian Sep 25, 2024
adf815d
Remove dry by fix of type widening in declaration files.
dragomirtitian Sep 27, 2024
91da5ae
Reverted emit to original in error case.
dragomirtitian Sep 27, 2024
ea932e6
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Sep 27, 2024
cbab1c7
Added indirection to preserve the initial intent of the tests.
dragomirtitian Sep 27, 2024
cae847a
Removed redundant error
dragomirtitian Sep 27, 2024
de8396e
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Sep 27, 2024
4bb04c0
Fixed formatting
dragomirtitian Sep 27, 2024
5f51c8c
Merge remote-tracking branch 'remotes/origin/main' into isolated-decl…
dragomirtitian Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed formatting
  • Loading branch information
@dragomirtitian
dragomirtitian committed Sep 27, 2024
commit 4bb04c0fbdc5ce3229ecd4d4642f7c7b2f4bba20
2 changes: 1 addition & 1 deletion src/compiler/expressionToTypeNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ export function createSyntacticTypeNodeBuilder(
result = serializeTypeAnnotationOfDeclaration(declaredType, context, node, symbol);
}
const oldSuppressReportInferenceFallback = context.suppressReportInferenceFallback;
context.suppressReportInferenceFallback = true
context.suppressReportInferenceFallback = true;
const resultType = result ?? inferTypeOfDeclaration(node, symbol, context, /*reportFallback*/ false);
context.suppressReportInferenceFallback = oldSuppressReportInferenceFallback;
return resultType;
Expand Down