Skip to content

Disallow let in let/const declaration regardless of target#5898

Merged
yuit merged 4 commits into
masterfrom
fix3475_let
Dec 4, 2015
Merged

Disallow let in let/const declaration regardless of target#5898
yuit merged 4 commits into
masterfrom
fix3475_let

Conversation

@yuit

@yuit yuit commented Dec 2, 2015

Copy link
Copy Markdown
Contributor

fix #3475

Comment thread src/compiler/checker.ts Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making this a check on variableList.declaration.length > 0. @vladima might be able to weigh in on if this sort of thing causes de-opts.

@mhegazy

mhegazy commented Dec 3, 2015

Copy link
Copy Markdown
Contributor

LGTM

yuit added a commit that referenced this pull request Dec 4, 2015
Disallow let in let/const declaration regardless of target
@yuit
yuit merged commit 3a4ac33 into master Dec 4, 2015
@yuit
yuit deleted the fix3475_let branch December 4, 2015 06:27
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'let' should not be allowed to be bound as a variable in a for-of loop or let/const decl

4 participants