Respect root dir/common src dir when generating module names#5881
Merged
Conversation
Contributor
There was a problem hiding this comment.
this should not change... the file name specified is "inputFile3"
Member
Author
There was a problem hiding this comment.
This is as a result of the canonicalization now performed on the file name in order to get the whole path (and then trim off the common part).
I suppose I could rework the comparison so not canonicalize and split, but instead compare canonicalized components and join, in order to preserve input casing on case insensitive systems.
Contributor
|
👍 thanks! |
weswigham
added a commit
that referenced
this pull request
Dec 2, 2015
Respect root dir/common src dir when generating module names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5819.
The root of the issue was that we weren't combining/separating paths correctly when joining/splitting the common source directory with the filename to generate the module name.