Skip to content

Add support for Chakra Host in sys.#5880

Merged
paulvanbrenk merged 3 commits into
masterfrom
supportChakra
Dec 4, 2015
Merged

Add support for Chakra Host in sys.#5880
paulvanbrenk merged 3 commits into
masterfrom
supportChakra

Conversation

@paulvanbrenk

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/compiler/sys.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line

Comment thread src/compiler/sys.ts Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these just be e.g. resolvePath: ChakraHost.resolvePath instead of wrappers?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good idea.

@mhegazy

mhegazy commented Dec 2, 2015

Copy link
Copy Markdown
Contributor

👍

@DanielRosenwasser

Copy link
Copy Markdown
Member

Should this be called NativeHost? It's not unreasonable to expect another host that exposes the same functionality.

@vladima

vladima commented Dec 2, 2015

Copy link
Copy Markdown
Contributor

👍

@yuit

yuit commented Dec 2, 2015

Copy link
Copy Markdown
Contributor

👍 @DanielRosenwasser is that what interface System for ?

paulvanbrenk added a commit that referenced this pull request Dec 4, 2015
Add support for Chakra Host in sys.
@paulvanbrenk
paulvanbrenk merged commit 2799d2e into master Dec 4, 2015
@paulvanbrenk
paulvanbrenk deleted the supportChakra branch December 4, 2015 04:59
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants