Skip to content

Correct regular expression flags scanning for non-BMP characters #58612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuckton merged 5 commits into from
Jun 4, 2024
Merged

Correct regular expression flags scanning for non-BMP characters #58612

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0725a3a
Correct flags scanning for non-BMP characters
graphemecluster May 22, 2024
f91f83f
Merge branch 'main' into regex-non-bmp-flags
graphemecluster May 30, 2024
406468c
Optimization: Lookup by `CharacterCodes`
graphemecluster May 30, 2024
723b1d6
Add remarks to test case file
rbuckton May 31, 2024
15783d6
Merge branch 'main' into regex-non-bmp-flags
graphemecluster May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into regex-non-bmp-flags 
Use `codePointChecked` instead of `charCodeChecked` in `reScanSlashToken`
  • Loading branch information
@graphemecluster
graphemecluster committed May 31, 2024
commit 15783d6bd1229d6614aca5f045ca052064e53ed9
2 changes: 1 addition & 1 deletion src/compiler/scanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2558,7 +2558,7 @@ export function createScanner(languageVersion: ScriptTarget, skipTrivia: boolean
pos++;
let regExpFlags = RegularExpressionFlags.None;
while (true) {
const ch = charCodeChecked(pos);
const ch = codePointChecked(pos);
if (ch === CharacterCodes.EOF || !isIdentifierPart(ch, languageVersion)) {
break;
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.