Skip to content

Lock down computed names in object literals and classes under --isolatedDeclarations #58596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weswigham merged 6 commits into from
May 22, 2024
Merged

Lock down computed names in object literals and classes under --isolatedDeclarations #58596

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
796e980
Lock down computed names in object literals and classes under --isola…
weswigham May 20, 2024
0a625ca
Add extra code to quickfix
weswigham May 21, 2024
23ccbfb
Remove currently dead branch from typeFromObjectLiteral
weswigham May 22, 2024
f13e96d
Remove now-unused emit resolver function
weswigham May 22, 2024
bcfdb73
Format & fix lints
weswigham May 22, 2024
d4a26b9
Undo breaking linter fix
weswigham May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add extra code to quickfix
  • Loading branch information
@weswigham
weswigham committed May 21, 2024
commit 0a625cad57a069e27bf30a354efe33f0002c8f0d
1 change: 1 addition & 0 deletions src/services/codefixes/fixMissingTypeAnnotationOnExports.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ const errorCodes = [
Diagnostics.Property_must_have_an_explicit_type_annotation_with_isolatedDeclarations.code,
Diagnostics.Expression_type_can_t_be_inferred_with_isolatedDeclarations.code,
Diagnostics.Binding_elements_can_t_be_exported_directly_with_isolatedDeclarations.code,
Diagnostics.Computed_property_names_on_class_or_object_literals_cannot_be_inferred_with_isolatedDeclarations.code,
Diagnostics.Computed_properties_must_be_number_or_string_literals_variables_or_dotted_expressions_with_isolatedDeclarations.code,
Diagnostics.Enum_member_initializers_must_be_computable_without_references_to_external_symbols_with_isolatedDeclarations.code,
Diagnostics.Extends_clause_can_t_contain_an_expression_with_isolatedDeclarations.code,
Expand Down