Skip to content

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheetalkamat merged 7 commits into from
May 21, 2024
Merged

Skip typechecking file when generating declaraiton to get d.ts signature for incremental build #58592

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac190d1
Experiment noChecking when forcing dts emit
sheetalkamat May 20, 2024
bf87f26
Tests failing
sheetalkamat May 20, 2024
23f7204
Collect aliases
sheetalkamat May 20, 2024
d9fce93
Emit with cancellation token enabled esp now that declaration emit ca…
sheetalkamat May 20, 2024
5cc1ea4
Remove debugging leftover
sheetalkamat May 20, 2024
0a23381
Check directly for forceDtsEmit before getting diagnostics and return…
sheetalkamat May 21, 2024
c4af1f5
Handle emitOnlyDts for now since #58364 is yet to be merged for js em…
sheetalkamat May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove debugging leftover
  • Loading branch information
@sheetalkamat
sheetalkamat committed May 20, 2024
commit 5cc1ea4887474ace8be203c7c36017af6828a329
2 changes: 1 addition & 1 deletion src/testRunner/unittests/tsc/cancellationToken.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
libFile,
} from "../helpers/virtualFileSystemWithWatch.js";

describe("unittests:: tsc:: builder cancellationToken:: sheetal", () => {
describe("unittests:: tsc:: builder cancellationToken::", () => {
Comment thread
sheetalkamat marked this conversation as resolved.
verifyCancellation(/*useBuildInfo*/ true, "when emitting buildInfo");
verifyCancellation(/*useBuildInfo*/ false, "when using state");
function verifyCancellation(useBuildInfo: boolean, scenario: string) {
Expand Down