Update unicode identifier start/part with more recent unicode version - #58521
Merged
Wesley Wigham (weswigham) merged 1 commit intoMay 13, 2024
Merged
Conversation
Wesley Wigham (weswigham)
requested review from
Jake Bailey (jakebailey) and
Ron Buckton (rbuckton)
May 13, 2024 17:45
Jake Bailey (jakebailey)
approved these changes
May 13, 2024
Jake Bailey (jakebailey)
left a comment
Member
There was a problem hiding this comment.
I could have sworn I sent a PR with this, but apparently not...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I glanced at the script folder and thought to myself "hey, when did we last run this?" and the answer is: 10 major node versions ago, which include 3 major unicode versions. We should probably run this whenever node major updates unicode, at least, so we properly support new character classes as identifiers (when they're classified as such).