Skip to content

Report RegExp errors in grammar check, use Annex B grammar #58295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbuckton merged 7 commits into from
Apr 24, 2024
Merged

Report RegExp errors in grammar check, use Annex B grammar #58295

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f105513
Report RegExp errors in grammar check, use Annex B grammar
rbuckton Apr 23, 2024
40ea4df
Revert change to incremental parser test
rbuckton Apr 23, 2024
48d0a0a
PR feedback
rbuckton Apr 24, 2024
aa8c585
Remove overaggressive assert
rbuckton Apr 24, 2024
19cb6ca
Fix format
rbuckton Apr 24, 2024
d67ab82
Use NodeCheckFlags.TypeChecked
rbuckton Apr 24, 2024
74d995c
Add test for `/=/`
rbuckton Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert change to incremental parser test
  • Loading branch information
@rbuckton
rbuckton committed Apr 23, 2024
commit 40ea4dfedd550099d82ea693235ea1f9e62c0a43
2 changes: 1 addition & 1 deletion src/compiler/scanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2492,7 +2492,7 @@ export function createScanner(languageVersion: ScriptTarget, skipTrivia: boolean
/** Grammar parameter */
const unicodeSetsMode = !!(regExpFlags & RegularExpressionFlags.UnicodeSets);
/** Grammar parameter */
const unicodeMode = unicodeSetsMode || !!(regExpFlags & RegularExpressionFlags.UnicodeMode); // v always implies u
const unicodeMode = !!(regExpFlags & RegularExpressionFlags.UnicodeMode);

if (unicodeMode) {
// Annex B treats any unicode mode as the strict syntax.
Expand Down
2 changes: 1 addition & 1 deletion src/testRunner/unittests/incrementalParser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ describe("unittests:: Incremental Parser", () => {
const oldText = ts.ScriptSnapshot.fromString(source);
const newTextAndChange = withInsert(oldText, semicolonIndex, "/");

compareTrees(oldText, newTextAndChange.text, newTextAndChange.textChangeRange, 4);
compareTrees(oldText, newTextAndChange.text, newTextAndChange.textChangeRange, 0);
Comment thread
rbuckton marked this conversation as resolved.
});

it("Regular expression 2", () => {
Expand Down