Remove some unneeded parameters from NodeBuilder APIs#57994
Merged
weswigham merged 2 commits intoMar 29, 2024
Conversation
weswigham
commented
Mar 28, 2024
| type Input = { | ||
| timer: Timer; | ||
| hook: Hook; | ||
| }; |
Member
Author
There was a problem hiding this comment.
The order private symbols get added to the output by the symbol tracker alone is potentially slightly different than the one you got when we were using both the symbol tracker and the includePrivateSymbol callback being passed around directly. It's just an artifact of the order the functions were getting called in. All the required ones still get added.
jakebailey
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
includePrivateSymbolbeing passed around became extraneous when the emitter started overriding theSymbolTrackerin the context with once that calls its' activeincludePrivateSymbolhook. Andbundledis just trivially calculable from the initial context information, and literally never changed as it was passed around.