Skip to content

Renamed functions, fixed signature, removed TODO#5782

Merged
DanielRosenwasser merged 1 commit into
masterfrom
renameStringLiteralTypeFunctions
Nov 25, 2015
Merged

Renamed functions, fixed signature, removed TODO#5782
DanielRosenwasser merged 1 commit into
masterfrom
renameStringLiteralTypeFunctions

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

getTypeFromStringLiteral sets resolvedType on a NodeLinks object, but resolvedType is only supposed to be set for type nodes.

@weswigham
Copy link
Copy Markdown
Member

👍 on the renaming

DanielRosenwasser added a commit that referenced this pull request Nov 25, 2015
Renamed functions, fixed signature, removed TODO
@DanielRosenwasser DanielRosenwasser merged commit 995f0c4 into master Nov 25, 2015
@DanielRosenwasser DanielRosenwasser deleted the renameStringLiteralTypeFunctions branch November 25, 2015 08:00
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants