Experimental variant on #57465 with two optimizations by danvk · Pull Request #57660 · microsoft/TypeScript

Dan Vanderkam (danvk) · 2024-03-06T16:42:39Z

This adds two optimizations to #57465:

For the false check, if trueType is a large union (20+ constituents) then split it into two chunks when calling getFlowTypeOfReference. The first chunk has the first 10 types, the second has the remainder. If the first chunk doesn't narrow to never then we don't have to check the second. This is a huge win on Use union types for all common classes of AST nodes #54148. On my laptop it reduces the time for the most extreme check from 312ms→140ms by only checking 10/112 types in the union. There are several other expensive calls on that PR that it's able to bypass as well. This has less of an effect on the Compiler-Unions benchmark.
A fast path for functions of the form x => x === y (or ==, !==, !=). These can only be type predicates if y is a unit type like null or undefined, but that can be expensive to determine via the usual calls to getFlowTypeOfReference if x and y are both large union types. In both Compiler-Unions and Use union types for all common classes of AST nodes #54148 there are some expensive checks that this bypasses, notably d => d === objectLiteralDeclaration.

In local testing these help on both Compiler-Unions and #54148. The x === y optimization is definitely targeted at a specific case in Compiler-Unions, but it's a win on #54148 as well, so perhaps it does generalize.

This reverts commit 4e79d76.

Jake Bailey (jakebailey) · 2024-03-06T16:43:51Z

TypeScript Bot (@typescript-bot) perf test this

TypeScript Bot (typescript-bot) · 2024-03-06T16:43:53Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

TypeScript Bot (typescript-bot) · 2024-03-06T17:23:54Z

Jake Bailey (@jakebailey)
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,565k (± 0.00%)}	_{295,585k (± 0.01%)}	_~	_295,516k	_295,620k	_{p=0.230 n=6}
_{Parse Time}	_{2.66s (± 0.28%)}	_{2.66s (± 0.51%)}	_~	_2.64s	_2.67s	_{p=0.672 n=6}
_{Bind Time}	_{0.83s (± 0.62%)}	_{0.83s (± 0.76%)}	_~	_0.82s	_0.84s	_{p=0.386 n=6}
_{Check Time}	_{8.22s (± 0.18%)}	_{8.21s (± 0.37%)}	_~	_8.19s	_8.27s	_{p=0.415 n=6}
_{Emit Time}	_{7.10s (± 0.43%)}	_{7.10s (± 0.19%)}	_~	_7.08s	_7.12s	_{p=0.806 n=6}
_{Total Time}	_{18.81s (± 0.14%)}	_{18.80s (± 0.14%)}	_~	_18.77s	_18.84s	_{p=0.627 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{192,120k (± 0.73%)}	_{192,445k (± 0.71%)}	_{+325k (+ 0.17%)}	_191,772k	_195,220k	_{p=0.045 n=6}
_{Parse Time}	_{1.35s (± 0.98%)}	_{1.37s (± 1.01%)}	_~	_1.35s	_1.38s	_{p=0.156 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.36s (± 0.50%)}	_{9.52s (± 0.32%)}	_{+0.16s (+ 1.71%)}	_9.47s	_9.55s	_{p=0.005 n=6}
_{Emit Time}	_{2.61s (± 0.66%)}	_{2.61s (± 0.78%)}	_~	_2.59s	_2.64s	_{p=0.870 n=6}
_{Total Time}	_{14.04s (± 0.35%)}	_{14.22s (± 0.22%)}	_{+0.18s (+ 1.26%)}	_14.17s	_14.26s	_{p=0.005 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,339k (± 0.00%)}	_{347,384k (± 0.00%)}	_{+45k (+ 0.01%)}	_347,370k	_347,395k	_{p=0.005 n=6}
_{Parse Time}	_{2.48s (± 0.42%)}	_{2.48s (± 0.47%)}	_~	_2.47s	_2.50s	_{p=0.801 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.56%)}	_~	_0.92s	_0.93s	_{p=1.000 n=6}
_{Check Time}	_{6.97s (± 0.34%)}	_{6.99s (± 0.34%)}	_~	_6.95s	_7.02s	_{p=0.056 n=6}
_{Emit Time}	_{4.06s (± 0.31%)}	_{4.09s (± 0.33%)}	_{+0.03s (+ 0.66%)}	_4.07s	_4.11s	_{p=0.014 n=6}
_{Total Time}	_{14.43s (± 0.25%)}	_{14.48s (± 0.22%)}	_{+0.05s (+ 0.35%)}	_14.43s	_14.52s	_{p=0.037 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,784k (± 0.01%)}	_{302,754k (± 0.01%)}	_~	_302,712k	_302,809k	_{p=0.128 n=6}
_{Parse Time}	_{2.00s (± 1.17%)}	_{2.00s (± 0.86%)}	_~	_1.98s	_2.03s	_{p=0.459 n=6}
_{Bind Time}	_{1.01s (± 1.31%)}	_{1.00s (± 1.04%)}	_~	_0.99s	_1.02s	_{p=0.451 n=6}
_{Check Time}	_{6.33s (± 0.28%)}	_{6.34s (± 0.49%)}	_~	_6.29s	_6.38s	_{p=0.803 n=6}
_{Emit Time}	_{3.61s (± 0.34%)}	_{3.61s (± 0.41%)}	_~	_3.59s	_3.63s	_{p=0.934 n=6}
_{Total Time}	_{12.96s (± 0.30%)}	_{12.95s (± 0.16%)}	_~	_12.93s	_12.99s	_{p=0.295 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{511,211k (± 0.00%)}	_{511,251k (± 0.01%)}	_~	_511,186k	_511,373k	_{p=0.078 n=6}
_{Parse Time}	_{2.65s (± 0.81%)}	_{2.66s (± 0.51%)}	_~	_2.64s	_2.67s	_{p=0.365 n=6}
_{Bind Time}	_{0.99s (± 0.99%)}	_{0.99s (± 1.23%)}	_~	_0.97s	_1.00s	_{p=0.865 n=6}
_{Check Time}	_{17.24s (± 0.23%)}	_{17.31s (± 0.50%)}	_~	_17.19s	_17.43s	_{p=0.146 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.88s (± 0.22%)}	_{20.95s (± 0.41%)}	_~	_20.84s	_21.08s	_{p=0.128 n=6}
_{mui-docs - node (v18.15.0, x64)}
_{Memory used}	_{2,296,341k (± 0.00%)}	_{2,296,522k (± 0.00%)}	_{+181k (+ 0.01%)}	_2,296,497k	_2,296,573k	_{p=0.005 n=6}
_{Parse Time}	_{11.98s (± 0.81%)}	_{11.97s (± 0.75%)}	_~	_11.87s	_12.13s	_{p=1.000 n=6}
_{Bind Time}	_{2.66s (± 0.69%)}	_{2.64s (± 0.31%)}	_~	_2.63s	_2.65s	_{p=0.121 n=6}
_{Check Time}	_{101.41s (± 0.87%)}	_{101.53s (± 0.66%)}	_~	_100.73s	_102.62s	_{p=1.000 n=6}
_{Emit Time}	_{0.32s (± 1.60%)}	_{0.32s (± 1.97%)}	_~	_0.31s	_0.33s	_{p=0.386 n=6}
_{Total Time}	_{116.37s (± 0.81%)}	_{116.47s (± 0.57%)}	_~	_115.64s	_117.55s	_{p=1.000 n=6}
_{self-build-src - node (v18.15.0, x64)}
_{Memory used}	_{2,394,444k (± 0.01%)}	_{2,396,586k (± 0.03%)}	_{+2,142k (+ 0.09%)}	_2,395,763k	_2,397,458k	_{p=0.005 n=6}
_{Parse Time}	_{5.04s (± 1.25%)}	_{5.05s (± 1.49%)}	_~	_4.94s	_5.14s	_{p=0.748 n=6}
_{Bind Time}	_{1.89s (± 0.43%)}	_{1.90s (± 0.86%)}	_~	_1.87s	_1.92s	_{p=0.605 n=6}
_{Check Time}	_{33.61s (± 0.31%)}	_{33.68s (± 0.22%)}	_~	_33.59s	_33.81s	_{p=0.173 n=6}
_{Emit Time}	_{2.64s (± 0.99%)}	_{2.66s (± 1.49%)}	_~	_2.59s	_2.70s	_{p=0.295 n=6}
_{Total Time}	_{43.19s (± 0.27%)}	_{43.30s (± 0.33%)}	_~	_43.17s	_43.52s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_{Memory used}	_{414,431k (± 0.01%)}	_{415,047k (± 0.01%)}	_{+616k (+ 0.15%)}	_415,001k	_415,088k	_{p=0.005 n=6}
_{Parse Time}	_{2.82s (± 0.70%)}	_{2.79s (± 0.84%)}	_~	_2.76s	_2.82s	_{p=0.087 n=6}
_{Bind Time}	_{1.07s (± 0.48%)}	_{1.07s (± 0.51%)}	_~	_1.06s	_1.07s	_{p=0.640 n=6}
_{Check Time}	_{15.14s (± 0.40%)}	_{15.26s (± 0.29%)}	_{+0.12s (+ 0.78%)}	_15.19s	_15.32s	_{p=0.008 n=6}
_{Emit Time}	_{1.10s (± 1.33%)}	_{1.11s (± 1.47%)}	_~	_1.08s	_1.12s	_{p=0.564 n=6}
_{Total Time}	_{20.13s (± 0.40%)}	_{20.22s (± 0.33%)}	_~	_20.13s	_20.32s	_{p=0.093 n=6}
_{vscode - node (v18.15.0, x64)}
_{Memory used}	_{2,859,177k (± 0.01%)}	_{2,859,763k (± 0.00%)}	_{+586k (+ 0.02%)}	_2,859,683k	_2,859,806k	_{p=0.005 n=6}
_{Parse Time}	_{10.76s (± 0.11%)}	_{10.76s (± 0.35%)}	_~	_10.71s	_10.81s	_{p=1.000 n=6}
_{Bind Time}	_{3.44s (± 0.12%)}	_{3.44s (± 0.34%)}	_~	_3.43s	_3.46s	_{p=0.584 n=6}
_{Check Time}	_{61.28s (± 0.29%)}	_{61.16s (± 0.55%)}	_~	_60.69s	_61.49s	_{p=0.688 n=6}
_{Emit Time}	_{17.41s (±10.15%)}	_{16.33s (± 0.40%)}	_~	_16.25s	_16.44s	_{p=0.810 n=6}
_{Total Time}	_{92.89s (± 1.89%)}	_{91.68s (± 0.36%)}	_~	_91.26s	_92.05s	_{p=0.173 n=6}
_{webpack - node (v18.15.0, x64)}
_{Memory used}	_{397,024k (± 0.01%)}	_{397,141k (± 0.02%)}	_{+117k (+ 0.03%)}	_397,049k	_397,211k	_{p=0.013 n=6}
_{Parse Time}	_{3.13s (± 0.94%)}	_{3.14s (± 0.77%)}	_~	_3.10s	_3.17s	_{p=0.373 n=6}
_{Bind Time}	_{1.38s (± 1.63%)}	_{1.39s (± 1.55%)}	_~	_1.37s	_1.43s	_{p=0.105 n=6}
_{Check Time}	_{13.93s (± 0.31%)}	_{14.06s (± 0.40%)}	_{+0.13s (+ 0.95%)}	_13.97s	_14.13s	_{p=0.008 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{18.44s (± 0.18%)}	_{18.60s (± 0.22%)}	_{+0.16s (+ 0.87%)}	_18.54s	_18.64s	_{p=0.005 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{513,132k (± 0.01%)}	_{513,198k (± 0.02%)}	_~	_513,106k	_513,414k	_{p=0.298 n=6}
_{Parse Time}	_{3.28s (± 0.36%)}	_{3.27s (± 0.37%)}	_~	_3.26s	_3.29s	_{p=0.507 n=6}
_{Bind Time}	_{1.54s (± 0.49%)}	_{1.54s (± 0.49%)}	_~	_1.53s	_1.55s	_{p=0.487 n=6}
_{Check Time}	_{2.86s (± 0.41%)}	_{2.87s (± 0.90%)}	_~	_2.83s	_2.90s	_{p=0.618 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.07s (± 0.00%)}	_{🟩-0.01s (-12.50%)}	_0.07s	_0.07s	_{p=0.001 n=6}
_{Total Time}	_{7.76s (± 0.28%)}	_{7.77s (± 0.35%)}	_~	_7.73s	_7.81s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,354ms (± 0.85%)}	_{2,365ms (± 0.58%)}	_~	_2,354ms	_2,391ms	_{p=0.230 n=6}
_{Req 2 - geterr}	_{5,580ms (± 1.00%)}	_{5,585ms (± 0.36%)}	_~	_5,564ms	_5,620ms	_{p=0.936 n=6}
_{Req 3 - references}	_{328ms (± 1.27%)}	_{330ms (± 0.97%)}	_~	_324ms	_333ms	_{p=0.624 n=6}
_{Req 4 - navto}	_{274ms (± 0.79%)}	_{274ms (± 0.00%)}	_~	_274ms	_274ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,357 (± 0.00%)}	_{1,357 (± 0.00%)}	_~	_1,357	_1,357	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{86ms (± 7.52%)}	_{79ms (± 0.65%)}	_~	_79ms	_80ms	_{p=0.103 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,522ms (± 0.42%)}	_{2,514ms (± 0.53%)}	_~	_2,493ms	_2,532ms	_{p=0.228 n=6}
_{Req 2 - geterr}	_{4,195ms (± 1.94%)}	_{4,177ms (± 0.52%)}	_~	_4,152ms	_4,214ms	_{p=1.000 n=6}
_{Req 3 - references}	_{344ms (± 6.92%)}	_{333ms (± 0.23%)}	_~	_332ms	_334ms	_{p=0.565 n=6}
_{Req 4 - navto}	_{284ms (± 1.03%)}	_{285ms (± 0.29%)}	_~	_285ms	_287ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,519 (± 0.00%)}	_{1,519 (± 0.00%)}	_~	_1,519	_1,519	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{81ms (± 8.93%)}	_{76ms (± 5.92%)}	_~	_74ms	_85ms	_{p=0.157 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,608ms (± 0.24%)}	_{2,597ms (± 0.67%)}	_~	_2,567ms	_2,620ms	_{p=0.170 n=6}
_{Req 2 - geterr}	_{1,750ms (± 2.03%)}	_{1,741ms (± 2.90%)}	_~	_1,659ms	_1,786ms	_{p=0.873 n=6}
_{Req 3 - references}	_{123ms (± 6.76%)}	_{118ms (± 9.54%)}	_~	_105ms	_128ms	_{p=0.872 n=6}
_{Req 4 - navto}	_{373ms (± 3.08%)}	_{369ms (± 1.30%)}	_~	_360ms	_373ms	_{p=0.936 n=6}
_{Req 5 - completionInfo count}	_{2,079 (± 0.00%)}	_{2,079 (± 0.00%)}	_~	_2,079	_2,079	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{305ms (± 1.08%)}	_{307ms (± 1.61%)}	_~	_301ms	_313ms	_{p=0.810 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{153.07ms (± 0.18%)}	_{153.08ms (± 0.17%)}	_~	_152.14ms	_155.04ms	_{p=0.618 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.04ms (± 0.17%)}	_{228.70ms (± 0.17%)}	_{-0.34ms (- 0.15%)}	_227.37ms	_231.75ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.72ms (± 0.17%)}	_{221.75ms (± 0.16%)}	_~	_219.92ms	_227.86ms	_{p=0.159 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{221.79ms (± 0.16%)}	_{221.78ms (± 0.15%)}	_~	_220.19ms	_226.38ms	_{p=0.991 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

Dan Vanderkam (danvk) · 2024-03-06T17:30:16Z

I'm surprised this wasn't a win. Might be time to stop optimizing this!

Dan Vanderkam (danvk) and others added 29 commits February 20, 2024 17:32

Infer type predicates from function bodies

0c24ccc

Run formatter

e2684f1

Add secondary subtype check and tests

101df93

add union type test to baselines

d0e385e

add prisma circularity test with failing baseline

a72b1f1

Various fixes for circularity issue

ef2d465

circularity test is fixed

9336052

revert back to CheckMode.TypeOnly

41f624d

Add test case for a predicate that throws

52df115

Drop isTriviallyNonBoolean, switch to simpler test, check for assertions

3ab6fae

Use unescapeLeadingUnderscores

9591231

tests are fixed

9a8c0a1

Always bind flow nodes to return statements + other fixes

a4ff6b4

Accept new baselines

869422f

Merge branch 'suggested-changes-57465' into infer-type-predicate-16069

adbdc7d

simplify

0dec9c6

Delay expensive functionHasImplicitReturn call

703253a

Avoid creating closures

c7f1c3d

Add fallback isTypeAssignableTo check to test for equivalence

25743a3

try caching the antecedent

4e79d76

revert fallback assignability check

a5725d2

Revert "try caching the antecedent"

3323573

This reverts commit 4e79d76.

Merge commit 'c7f1c3d309' into infer-type-predicate-16069

76a5abd

implement the never bailout

8edd119

attempt to implement === fast path

9479ed8

add === test and baselines

f833865

make at most two calls to getFTOR for big unions

51a8970

comments, format

348509a

getTypeOfExpression -> checkExpressionCached

fd8db07

TypeScript Bot (typescript-bot) added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Mar 6, 2024

Dan Vanderkam (danvk) closed this Mar 6, 2024

Dan Vanderkam (danvk) mentioned this pull request Mar 6, 2024

Infer type predicates from function bodies using control flow analysis #57465

Merged

Dan Vanderkam (danvk) mentioned this pull request Apr 2, 2024

Fixed type predicate inference for discriminated union parameters #57952

Merged

Microsoft (microsoft) locked as resolved and limited conversation to collaborators Oct 16, 2025

Navigation Menu

Uh oh!

Experimental variant on #57465 with two optimizations - #57660

Experimental variant on #57465 with two optimizations#57660
Dan Vanderkam (danvk) wants to merge 29 commits into
microsoft:mainfrom
danvk:never-bailout

Dan Vanderkam (danvk) commented Mar 6, 2024

Uh oh!

Jake Bailey (jakebailey) commented Mar 6, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 6, 2024 •

edited

Loading

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 6, 2024

tsc

tsserver

startup

Uh oh!

Dan Vanderkam (danvk) commented Mar 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Dan Vanderkam (danvk) commented Mar 6, 2024

Uh oh!

Jake Bailey (jakebailey) commented Mar 6, 2024

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TypeScript Bot (typescript-bot) commented Mar 6, 2024

tsc

tsserver

startup

Uh oh!

Dan Vanderkam (danvk) commented Mar 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TypeScript Bot (typescript-bot) commented Mar 6, 2024 •

edited

Loading