Skip to content

cleanup harness code (part 3)#5697

Merged
vladima merged 2 commits into
harnessCleanup2_WIPfrom
harnessCleanup3_WIP
Nov 16, 2015
Merged

cleanup harness code (part 3)#5697
vladima merged 2 commits into
harnessCleanup2_WIPfrom
harnessCleanup3_WIP

Conversation

@vladima
Copy link
Copy Markdown
Contributor

@vladima vladima commented Nov 16, 2015

  1. dropped Tao tests generation as it does not seem to be used
  2. switch fourslash from using global currentTestState to local test state. The effect of this change:
    • generated test files are smaller since all runtime infrastructure is moved to core fourslash bits - less code to eval
    • fourslash.ts used by tests now stores only declarations so it is smaller - less code to parse/typecheck

@RyanCavanaugh
Copy link
Copy Markdown
Member

👍 🏆

vladima added a commit that referenced this pull request Nov 16, 2015
@vladima vladima merged commit 7d65b5b into harnessCleanup2_WIP Nov 16, 2015
@vladima vladima deleted the harnessCleanup3_WIP branch November 16, 2015 23:20
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

namespace instead of module?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be, but I decided to delete it instead :) nobody was using it anymore

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants