Skip to content

Add NoInfer<T> intrinsic represented as special substitution type #56794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 10 commits into from
Jan 12, 2024
Merged

Add NoInfer<T> intrinsic represented as special substitution type #56794

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ba7f084
Add NoInfer<T> intrinsic represented as special substitution type
ahejlsberg Dec 15, 2023
411205e
Update tests
ahejlsberg Dec 15, 2023
b25bf3e
Add tests
ahejlsberg Dec 15, 2023
9438168
Erase NoInfer<T> in index types
ahejlsberg Dec 18, 2023
e492451
Add tests
ahejlsberg Dec 18, 2023
63b6713
keyof NoInfer<T> ==> NoInfer<keyof T> / globalThis emit when needed
ahejlsberg Dec 20, 2023
14b90c2
Simplify keyof NoInfer<T> ==> NoInfer<keyof T> transformation
ahejlsberg Dec 20, 2023
2fc975a
Update tests
ahejlsberg Dec 20, 2023
af2aae4
Merge branch 'main' into fix14829
ahejlsberg Jan 9, 2024
79f8513
Add test for redeclaration of NoInfer<T>
ahejlsberg Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Simplify keyof NoInfer<T> ==> NoInfer<keyof T> transformation
  • Loading branch information
@ahejlsberg
ahejlsberg committed Dec 20, 2023
commit 14b90c23ca311981a1b7495437162999a730c634
6 changes: 3 additions & 3 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17760,7 +17760,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}

function shouldDeferIndexType(type: Type, indexFlags = IndexFlags.None) {
return !!(type.flags & TypeFlags.InstantiableNonPrimitive && !isNoInferType(type) ||
return !!(type.flags & TypeFlags.InstantiableNonPrimitive ||
isGenericTupleType(type) ||
isGenericMappedType(type) && (!hasDistributiveNameType(type) || getMappedTypeNameTypeKind(type) === MappedTypeNameTypeKind.Remapping) ||
type.flags & TypeFlags.Union && !(indexFlags & IndexFlags.NoReducibleCheck) && isGenericReducibleType(type) ||
Expand All @@ -17769,10 +17769,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {

function getIndexType(type: Type, indexFlags = defaultIndexFlags): Type {
type = getReducedType(type);
return shouldDeferIndexType(type, indexFlags) ? getIndexTypeForGenericType(type as InstantiableType | UnionOrIntersectionType, indexFlags) :
return isNoInferType(type) ? getNoInferType(getIndexType((type as SubstitutionType).baseType, indexFlags)) :
shouldDeferIndexType(type, indexFlags) ? getIndexTypeForGenericType(type as InstantiableType | UnionOrIntersectionType, indexFlags) :
type.flags & TypeFlags.Union ? getIntersectionType(map((type as UnionType).types, t => getIndexType(t, indexFlags))) :
type.flags & TypeFlags.Intersection ? getUnionType(map((type as IntersectionType).types, t => getIndexType(t, indexFlags))) :
type.flags & TypeFlags.Substitution ? getNoInferType(getIndexType((type as SubstitutionType).baseType, indexFlags)) :
getObjectFlags(type) & ObjectFlags.Mapped ? getIndexTypeForMappedType(type as MappedType, indexFlags) :
type === wildcardType ? wildcardType :
type.flags & TypeFlags.Unknown ? neverType :
Expand Down