Skip to content

do not crash when variable and function declarations collide#5670

Merged
vladima merged 1 commit into
masterfrom
noCrashWithNonMergedOverloads
Nov 14, 2015
Merged

do not crash when variable and function declarations collide#5670
vladima merged 1 commit into
masterfrom
noCrashWithNonMergedOverloads

Conversation

@vladima
Copy link
Copy Markdown
Contributor

@vladima vladima commented Nov 14, 2015

fixes #5160

@DanielRosenwasser
Copy link
Copy Markdown
Member

👍

vladima added a commit that referenced this pull request Nov 14, 2015
do not crash when variable and function declarations collide
@vladima vladima merged commit abb7a13 into master Nov 14, 2015
@vladima vladima deleted the noCrashWithNonMergedOverloads branch November 14, 2015 21:18
@paulvanbrenk
Copy link
Copy Markdown
Contributor

Can you create a PR to cherry pick this into release 1.7? Then I'll check if we can add this.

@vladima
Copy link
Copy Markdown
Contributor Author

vladima commented Nov 14, 2015

this new PR will conflict with #5664 since they change the same part of the code. Can we just include this change as another commit to #5664

@paulvanbrenk
Copy link
Copy Markdown
Contributor

Sure, can you add this to #5664? Then I'll see if we can actually take these fixes.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Nov 14, 2015

Lets get this in 1.7 as well

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compiler crash when variable has same name as a function with overloads

5 participants