pass 'detached:true' for diff tool#56293
Conversation
jakebailey
left a comment
There was a problem hiding this comment.
To be honest I didn't even know anyone used this and considered removing it... I just diff using a shell alias as the diff command we have in CONTRIBUTING is extremely useful elsewhere.
| else { | ||
| proc.unref(); | ||
| // wait a short period in order to allow the process to start successfully before Node exits. | ||
| setTimeout(() => resolve({ exitCode: undefined }), 100); |
There was a problem hiding this comment.
Doesn't someone still need to resolve this promise? Otherwise hereby will just keep running? (I haven't tested quite yet)
There was a problem hiding this comment.
Ah, fair point. I'll fix.
I use this quite regularly. |
|
Tested this out locally, and it seems like output doesn't appear: But, it also doesn't show up on |
|
Ah, the |
|
Oh, gotcha. Not a regression, of course, just not what I thought it was for. |
Properly detach subprocess when spawning diff tool for
hereby diffso that it doesn't terminate immediately when the NodeJS process terminates.