[Reference] feat: switched Node to a discriminated union - #56274
Closed
Josh Goldberg ✨ (JoshuaKGoldberg) wants to merge 1 commit into
Closed
[Reference] feat: switched Node to a discriminated union#56274Josh Goldberg ✨ (JoshuaKGoldberg) wants to merge 1 commit into
Josh Goldberg ✨ (JoshuaKGoldberg) wants to merge 1 commit into
Conversation
5 tasks
Contributor
|
If you're interested, we have discussed this in the engine262 repo. engine262/engine262#215 (comment) I really hope this can land, but I think there might be performance pushback. |
Member
|
Yes; the previous iteration caused check time to triple: #54148 |
Contributor
Author
|
Closing to keep the review queue small. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posting as reference for now. Still has build failures. Not ready for review.
Naming is not at all well-thought-out. Names like
NodeBaseare just what came to mind first.The most breaking portion of this PR's change is that
Nodeno longer has aparent: Node, becauseSourceFilehasparent: undefined. In retrospect this probably could be split into >= two steps:parent: NodeinsideSourceFileparent: Nodetoparent: undefinedinsideSourceFile