use modulekind to check if initializer for shorthand property assignm…#5576
Merged
Conversation
…ent should be emitted
Member
There was a problem hiding this comment.
Are these three errors part of the test? From reading the bug, it looks like only foo1 and const test = { x }; are needed and the rest can be removed.
Contributor
Author
There was a problem hiding this comment.
console is irrelevant, However missing ./foo2 module is necessary to make sure that we emit the right thing no matter whether module is found or not.
Member
There was a problem hiding this comment.
Can you name the modules found.ts/notFound.ts then?
Member
|
Looks good except for maybe some test cleanup. |
Contributor
|
👍 |
vladima
added a commit
that referenced
this pull request
Nov 9, 2015
use modulekind to check if initializer for shorthand property assignm…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ent should be emitted. Fixes #5573