Use ts.indexOf instead of Array.prototype.indexOf#5569
Merged
Conversation
(keep consistent with the rest of codebase, and thus enable ES3-compatibility of tsc and services)
(keep consistent with the rest of codebase, and thus enable ES3-compatibility of tsc and services)
Contributor
|
thanks @mihailik. Do you mind signing the CLA. |
MartyIX
referenced
this pull request
in MartyIX/TypeScript
Nov 9, 2015
Contributor
Author
|
I'm sorry that CLA is a bit complicated logistics with my employer. The changes are trivial, would you please accept if I split PR in two seprate ones? |
Member
|
@mhegazy do we have the ability to decide this is a non-CLA trivial change? |
Contributor
|
@mihailik the CLA has recently changed and does not require your employer approval if you are doing this on your own time. |
mhegazy
added a commit
that referenced
this pull request
Nov 11, 2015
Use ts.indexOf instead of Array.prototype.indexOf
Contributor
|
thanks @mihailik. |
Contributor
Author
|
Cheers! Signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ts.indexOfis employed instead ofArray.prototype.indexOfconsistently across tsc/services codebase for the sake of ES3-compatibility.Once in a while somebody checks in code breaking that edge case, and in time I (or somebody else) pick on that and offer a patch.
This is one of those cases.
Please don't break ES3-compatibility intentionally. For occasional unintentional breaks I'll try to keep up.
Many thanks!