A few perf-related low hanging fruits#5561
Merged
Merged
Conversation
…cess, use one constructor function for all nodes
Member
There was a problem hiding this comment.
can you use a for..of?
Member
|
Apart from my comments, 👍 |
Member
There was a problem hiding this comment.
kind should be the first parameter.
Contributor
Author
|
@ahejlsberg we cannot just use |
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Member
|
👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 👏 |
vladima
added a commit
that referenced
this pull request
Nov 9, 2015
A few perf-related low hanging fruits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceFilewith local variables to reduce amount of polymorphismNodeitself.This shaves off ~10% of overall compilation time in our perf tests