Changes to typeWriter and type baselines#554
Merged
Merged
Conversation
Contributor
Author
|
The Travis failure is a known issue #555 |
Contributor
There was a problem hiding this comment.
i would remove this, i do not think it makes sense to specialize this.
Contributor
Author
There was a problem hiding this comment.
Logging a bug for it (#559) and reverting back to original behavior.
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
probably do not need useTypeOfFunction flag as well.
Contributor
|
👍 |
Contributor
Author
|
I am not sure why the Travis build is failing. I am unable to reproduce the 2 test failures locally. |
Contributor
Author
|
Travis seems to be running the tests from master on the typeBaselines branch. |
JsonFreeman
added a commit
that referenced
this pull request
Aug 29, 2014
Changes to typeWriter and type baselines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not to be merged in wholesale. I am just documenting the changes I've made in this branch to compare the type baselines with the old compiler's type baselines. The changes were in the service of making the new baselines and old baselines look as similar as possible. The idea is to pick and choose the changes we actually want to port to master. Various smaller / more nuanced differences were captured in the form of bugs with the prefix [typeBaselines]. The majority of the changes ported should be source changes, but a few test changes may be ported as well.