Fix union type partial signature matching#5459
Merged
Merged
Conversation
Member
Author
|
@sandersn This is the best way to fix the issue. We were a bit too permissive in partial signature matches involving rest parameters. |
Member
There was a problem hiding this comment.
Why does a partial match return Ternary.False when partialMatch === true?
Member
There was a problem hiding this comment.
I don't believe that's what actually happens. If both sides of the || are Ternary.False, you'll return Ternary.False
Member
There was a problem hiding this comment.
Ah, I didn't see the parentheses surrounding the whole thing. I thought it was !isMatchingSignature(...) ||. Now it makes sense.
Member
|
👍 with the comment that I like Daniel's name change idea. |
ahejlsberg
added a commit
that referenced
this pull request
Nov 6, 2015
Fix union type partial signature matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5401.