Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, and @minestarks for you. Feel free to loop in other consumers/maintainers if necessary

Seems unused from what I can tell:

https://github.com/search?q=tsserver+%5C%22occurrences%5C%22+OR+%5C%27occurrences%5C%27+NOT+path%3A%2F%5Esrc%5C%2FtestRunner%5C%2Funittests%5C%2Ftsserver%5C%2F%2F+NOT+language%3AMarkdown+path%3A+NOT+path%3A%2F%5Esrc%5C%2Fserver%5C%2F%2F+NOT+path%3A%2F%5C.d%5C.ts%24%2F++NOT+path%3AtsserverProjectSystem.ts+NOT+path%3A.pnpm-store&type=code

Code itself looks good to me, but @mjbvz and @zkat should probably sign off for VS Code and VS respectively.

I do see one reference to this call from the same list as #52346 (comment) but it's in a long-dead project, so probably not a problem?

@sheetalkamat I'm going through all the ready-to-merge PRs, and this one seems worthwhile to merge. Given @jakebailey 's findings we might not need confirmation from @mjbvz or @zkat. What do you think?

I don't see any references to this in VS

Can you please update https://github.com/microsoft/TypeScript/wiki/API-Breaking-Changes ?

This broke Monaco, because they use occurrences: https://github.com/microsoft/TypeScript-Make-Monaco-Builds/actions/runs/4308395883/jobs/7514631424

Can we revert this until we get a replacement into Monaco? We can't produce any playground builds at the moment.

I guess I can just send a PR with copy/paste of https://github.com/microsoft/TypeScript/pull/52347/files#diff-68e0a0bdd65b7a9bb405747188b445f5836ab24070c3c06501a961d5d69c910bR3500?

I sent microsoft/monaco-editor#3619 so hopefully that's looked at soonish, but otherwise we might want to revert?

#53056 if we need to revert